Fix Json Schema validations for optional fields #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekkumams
requested review from
Aniruddh25,
RubenCerna2079,
aaronburtle,
neeraj-sharma2592,
ravishetye,
rohkhann,
sezal98 and
sourabh1007
as code owners
…d' of https://github.com/Azure/data-api-builder into dev/abhishekkuma/fix-schema-validation-no-optional-field
Contributor
Author
|
/azp run |
sezal98
approved these changes
Mar 13, 2025
Contributor
sezal98
left a comment
sezal98
left a comment
There was a problem hiding this comment.
Added new UT and reviewed PR
Contributor
|
/azp run |
RubenCerna2079
approved these changes
Mar 15, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
|
@microsoft-github-policy-service agree company="Microsoft" |
1 similar comment
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
sezal98
deleted the
dev/abhishekkuma/fix-schema-validation-no-optional-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
dab.draft.schema.jsonoptional field types withnullto allow for optional fields to be evaluated correctly during schema validation.How was this tested?
Sample Request(s)
config:
Before Fix:
After Fix:
